[PATCH] D45662: Fuzzer, add libcxx for OpenBSD

Dean Michael Berris via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Apr 15 23:08:06 PDT 2018


dberris added inline comments.


================
Comment at: lib/Driver/ToolChains/CommonArgs.cpp:678-679
       TC.AddCXXStdlibLibArgs(Args, CmdArgs);
+      if (TC.getTriple().getOS() == llvm::Triple::OpenBSD)
+        CmdArgs.push_back(Args.hasArg(options::OPT_pg) ? "-lc++_p" : "-lc++");
+    }
----------------
devnexen wrote:
> dberris wrote:
> > Maybe this should be in the `TC.AddCXXStdlibLibArgs(...)` function instead?
> I did not dare since it s the only case where it is needed (e.g. no need for X-ray for example)
Okay, let me ask this another way.

Is there ever a case for OpenBSD when we're doing `TC.AddCXXStdlibLibArgs(...)` that we don't need to also add these flags when `OPT_pg` is specified?


Repository:
  rC Clang

https://reviews.llvm.org/D45662





More information about the cfe-commits mailing list