[PATCH] D45476: [C++2a] Implement operator<=> CodeGen and ExprConstant

[Eric Fiselier via Phabricator via cfe-commits]

EricWF added inline comments.


================
Comment at: lib/Sema/SemaExpr.cpp:9928
+    // result is of type std::strong_equality
+    if (CompositeTy->isFunctionPointerType() ||
+        CompositeTy->isMemberPointerType() || CompositeTy->isNullPtrType())
----------------
EricWF wrote:
> rsmith wrote:
> > Please add a FIXME here to consider making the function pointer case produce strong_ordering not strong_equality, per P0946R0-Jax18 discussion / direction polls.
> Is it OK if I go ahead and implement it anyway?
Nevermind. The changes seems involved enough they should be done separately. 


https://reviews.llvm.org/D45476