[PATCH] D44984: [HIP] Add hip file type and codegen for kernel launching
Yaxun Liu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Apr 13 08:35:47 PDT 2018
yaxunl marked 4 inline comments as done.
yaxunl added inline comments.
================
Comment at: lib/Frontend/CompilerInvocation.cpp:2109
+ Opts.HIP = true;
+ }
+
----------------
rjmccall wrote:
> Why is this done here? We infer the language mode from the input kind somewhere else.
It is usually done through CompilerInvocation::setLangDefaults. However, HIP does not have its own input kind nor is it defined as a language standard. Therefore it cannot use CompilerInvocation::setLangDefaults to set Opts.HIP.
https://reviews.llvm.org/D44984
More information about the cfe-commits
mailing list