[PATCH] D45476: [C++2a] Implement operator<=> CodeGen and ExprConstant

[Eric Fiselier via Phabricator via cfe-commits]

EricWF updated this revision to Diff 142326.
EricWF added a comment.

Address most of @rsmith's comments.

- Back out changes to `Expr.h`.
- Build comparison category types as needed, not eagerly.
- Remove diagnostics about non-constexpr narrowing.

@rsmith I also tried to modify `ExprConstant` as requested, but I'm not sure I ended up with something better. But at least I'm no longer building a dummy `BinaryOperator` expression.
Let me know what you think.


https://reviews.llvm.org/D45476

Files:
  include/clang/AST/ASTContext.h
  include/clang/AST/ComparisonCategories.h
  include/clang/Basic/DiagnosticSemaKinds.td
  include/clang/Sema/Overload.h
  include/clang/Sema/Sema.h
  lib/AST/CMakeLists.txt
  lib/AST/ComparisonCategories.cpp
  lib/AST/ExprConstant.cpp
  lib/CodeGen/CGExprAgg.cpp
  lib/Sema/SemaDeclCXX.cpp
  lib/Sema/SemaExpr.cpp
  lib/Sema/SemaOverload.cpp
  test/CodeGenCXX/Inputs/std-compare.h
  test/CodeGenCXX/cxx2a-compare.cpp
  test/PCH/Inputs/std-compare.h
  test/PCH/cxx2a-compare.cpp
  test/SemaCXX/Inputs/std-compare.h
  test/SemaCXX/compare-cxx2a.cpp
  test/SemaCXX/constant-expression-cxx2a.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D45476.142326.patch
Type: text/x-patch
Size: 137578 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180413/bf609179/attachment-0001.bin>