[PATCH] D45529: [CMake] Set the default ABI version for Fuchsia in CMake as well

Petr Hosek via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 12 15:23:34 PDT 2018


phosek added a comment.

In https://reviews.llvm.org/D45529#1066394, @EricWF wrote:

> OK, so we need to bump the SO version -- However I don't want to generate a __site_config header because of that if the __config header is sufficient. I would like to see a solution that takes that into account.


There shouldn't be any `__site_config` generated now since we compare `LIBCXX_ABI_VERSION` to the default version so it'll only be generated if the change the default value (2 on Fuchsia, 1 everywhere else).


Repository:
  rCXX libc++

https://reviews.llvm.org/D45529





More information about the cfe-commits mailing list