[PATCH] D45532: [StaticAnalyzer] Checker to find uninitialized fields after a constructor call
Umann Kristóf via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Apr 11 11:53:09 PDT 2018
Szelethus added a comment.
In https://reviews.llvm.org/D45532#1064652, @NoQ wrote:
> > In most cases, all fields of a union is regarded as unknown. I checked these cases by regarding unknown fields as uninitialized.
>
> The whole point of making them unknown, as far as i understand, was to suppress uninitialized field warnings. So i feel what we're doing here is a bit upside down.
I wasn't too clear on this one: unknown fields are regarded as uninitialized, what I wrote was a temporary change in the code so I could check whether it would work.
I agree with you regarding unions, and will remove the code that relies on non existing implementation.
https://reviews.llvm.org/D45532
More information about the cfe-commits
mailing list