[PATCH] D45304: [libcxx] Set ABI version 2 as default for Fuchsia

[Eric Fiselier via Phabricator via cfe-commits]

EricWF added inline comments.


================
Comment at: libcxx/CMakeLists.txt:100
         "LIBCXX_ENABLE_EXPERIMENTAL_LIBRARY;LIBCXX_INSTALL_LIBRARY" OFF)
-set(LIBCXX_ABI_VERSION 1 CACHE STRING "ABI version of libc++.")
+if (FUCHSIA)
+  set(ABI_VERSION_DEFAULT 2)
----------------
I don't think this part of the change is needed. Won't setting ABI_VERSION_DEFAULT to 2 result in a site config header being generated?


Repository:
  rCXX libc++

https://reviews.llvm.org/D45304