[PATCH] D44093: [BUILTINS] structure pretty printer

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 10 11:56:00 PDT 2018


aaron.ballman added a comment.

Can you rebase the patch? The patch did not apply cleanly for me against trunk (the contents of the check function are appearing in `CheckARMBuiltinExclusiveCall()`).

(Also, one tiny nit about escaped characters that can be fixed at the same time.)



================
Comment at: lib/Sema/SemaChecking.cpp:1133
+      Diag(FnPtrArg->getLocStart(), diag::err_typecheck_convert_incompatible)
+          << FnPtrArgType << "\'int (*)(const char *, ...)\'" << 1 << 0 << 3
+          << 2 << FnPtrArgType << "\'int (*)(const char *, ...)\'";
----------------
Minor nit: can you remove the escape character for the single quotes (here and elsewhere in the patch), as there's no need to escape that character?


Repository:
  rC Clang

https://reviews.llvm.org/D44093





More information about the cfe-commits mailing list