[PATCH] D45414: [clang-tidy] add missing assignment operations in hicpp-signed-bitwise
Aaron Ballman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Apr 10 08:20:13 PDT 2018
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LG aside from a diagnostic wording nit.
================
Comment at: clang-tidy/hicpp/SignedBitwiseCheck.cpp:92
+ if (N.getNodeAs<NamedDecl>("std_type"))
+ diag(Location, "shifting a value of the standardized bitmask types");
+ else
----------------
How about: "shifting a value of bitmask type"
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45414
More information about the cfe-commits
mailing list