[PATCH] D45485: [CMake] Unbreak BUILD_SHARED_LIBS workflow

David Zarzycki via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 10 05:57:19 PDT 2018


davezarzycki created this revision.
davezarzycki added reviewers: mspertus, beanz, gottesmm.
Herald added a subscriber: mgorny.

Due to recent timer changes, we need to add LLVM's `Core` library to avoid undefined symbol errors at link time (`llvm::TimePassesIsEnabled`) when using LLVM's BUILD_SHARED_LIBS workflow.


Repository:
  rC Clang

https://reviews.llvm.org/D45485

Files:
  lib/Frontend/CMakeLists.txt
  lib/Lex/CMakeLists.txt
  lib/Parse/CMakeLists.txt
  lib/Sema/CMakeLists.txt


Index: lib/Sema/CMakeLists.txt
===================================================================
--- lib/Sema/CMakeLists.txt
+++ lib/Sema/CMakeLists.txt
@@ -1,4 +1,5 @@
 set(LLVM_LINK_COMPONENTS
+  Core
   Support
   )
 
Index: lib/Parse/CMakeLists.txt
===================================================================
--- lib/Parse/CMakeLists.txt
+++ lib/Parse/CMakeLists.txt
@@ -1,4 +1,5 @@
 set(LLVM_LINK_COMPONENTS
+  Core
   MC
   MCParser
   Support
Index: lib/Lex/CMakeLists.txt
===================================================================
--- lib/Lex/CMakeLists.txt
+++ lib/Lex/CMakeLists.txt
@@ -1,6 +1,9 @@
 # TODO: Add -maltivec when ARCH is PowerPC.
 
-set(LLVM_LINK_COMPONENTS support)
+set(LLVM_LINK_COMPONENTS
+  Core
+  support
+  )
 
 add_clang_library(clangLex
   HeaderMap.cpp
Index: lib/Frontend/CMakeLists.txt
===================================================================
--- lib/Frontend/CMakeLists.txt
+++ lib/Frontend/CMakeLists.txt
@@ -1,6 +1,7 @@
 add_subdirectory(Rewrite)
 
 set(LLVM_LINK_COMPONENTS
+  Core
   BitReader
   Option
   ProfileData


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D45485.141829.patch
Type: text/x-patch
Size: 1091 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180410/e4bac58d/attachment-0001.bin>


More information about the cfe-commits mailing list