[PATCH] D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting.

[Malcolm Parsons via Phabricator via cfe-commits]

malcolm.parsons added a comment.

In https://reviews.llvm.org/D43764#1062748, @jdemeule wrote:

> Ok, I understand the problem.
>  Previously, during the deduplication step, replacements per file where sorted and it is not the case anymore.
>  That means now, clang-apply-replacement is highly dependant of reading file order during error reporting.
>  I mainly see 2 options (I can miss others), rewrite the test (e.g merging yaml file together) or sort the replacements per file to fix the order of application.
>
> Can I ask you what solution you prefer?


I'd prefer sorting, so that results will be consistent when the tool is used on real data.


https://reviews.llvm.org/D43764