[PATCH] D45059: [clang-tidy] Add check to catch comparisons in TEMP_FAILURE_RETRY

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 9 12:48:12 PDT 2018


aaron.ballman accepted this revision.
aaron.ballman added a comment.

LGTM with a few minor nits to be fixed.



================
Comment at: docs/clang-tidy/checks/android-comparison-in-temp-failure-retry.rst:4
+android-comparison-in-temp-failure-retry
+=========================================
+
----------------
Underlining is off here.


================
Comment at: docs/clang-tidy/checks/android-comparison-in-temp-failure-retry.rst:25
+
+Since TEMP_FAILURE_RETRY will check for whether the result *of the comparison*
+is ``-1``, and retry if so.
----------------
s/Since/Because


https://reviews.llvm.org/D45059





More information about the cfe-commits mailing list