[PATCH] D45444: [clang-tidy] WIP: implement new check for const-correctness
Eugene Zelenko via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Apr 9 11:01:14 PDT 2018
Eugene.Zelenko added a comment.
It'll be good idea to have option to apply this check for pointer/references only, or include built-in types/enums.
================
Comment at: clang-tidy/cppcoreguidelines/ConstCheck.cpp:13
+#include "clang/ASTMatchers/ASTMatchFinder.h"
+
+#include <iostream>
----------------
Please remove empty line.
================
Comment at: docs/ReleaseNotes.rst:60
+- New :doc:`cppcoreguidelines-const
+ <clang-tidy/checks/cppcoreguidelines-const>` check
----------------
Please move into new checks list in alphabetical order.
================
Comment at: docs/ReleaseNotes.rst:63
+
+ FIXME: add release notes.
+
----------------
Please add short description here.
================
Comment at: docs/clang-tidy/checks/cppcoreguidelines-const.rst:6
+
+FIXME: Describe what patterns does the check detect and why. Give examples.
----------------
Preliminary documentation will be helpful.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45444
More information about the cfe-commits
mailing list