[PATCH] D45094: [LibTooling] Make interface of VFS injection into ClangTool more user-friendly

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added inline comments.


================
Comment at: include/clang/Basic/VirtualFileSystem.h:315
+IntrusiveRefCntPtr<OverlayFileSystem>
+createOverlayOnRealFilesystem(IntrusiveRefCntPtr<FileSystem> TopFS);
+
----------------
NIT: I'm not an expert in English, but shouldn't it be createOverlay**Over**Real.....
Also maybe shorten the suffix: `createOverlayOverRealFS`?


================
Comment at: lib/Basic/VirtualFileSystem.cpp:372
+vfs::createOverlayOnRealFilesystem(IntrusiveRefCntPtr<FileSystem> TopFS) {
+  IntrusiveRefCntPtr<OverlayFileSystem> OverlayFS =
+    new OverlayFileSystem(getRealFileSystem());
----------------
Maybe add an assert the parameter is non-null?


https://reviews.llvm.org/D45094