[PATCH] D38455: [clang-tidy] new cppcoreguidelines-narrowing-conversions check.
Jonas Toth via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Apr 9 04:03:48 PDT 2018
JonasToth added a comment.
> Is there anything I need to do for the diff to change state ? I
thought updating the code would automatically mark it "ready for review"
again.
I think all comments must be marked as done to be ready for review
again. Usually the reviewer reacts to changed code, too.
But aaron seems busy right now and i think alexfh did disable the
notifications for now. Add/ping him again.
Am 09.04.2018 um 12:55 schrieb Clement Courbet via Phabricator:
> courbet added a comment.
>
> In https://reviews.llvm.org/D38455#1061300, @JonasToth wrote:
>
>> That sounds good.
>>
>>> Removing from my dashboard for now.
>>
>> maybe you should add alexfh again and discuss the results.
>
> Is there anything I need to do for the diff to change state ? I thought updating the code would automatically mark it "ready for review" again.
>
> Repository:
>
> rCTE Clang Tools Extra
>
> https://reviews.llvm.org/D38455
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D38455
More information about the cfe-commits
mailing list