[PATCH] D45006: [Tooling] A CompilationDatabase wrapper that infers header commands.

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 9 02:35:22 PDT 2018


ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.

LGTM with a small nit.
Really excited about this landing!



================
Comment at: lib/Tooling/InterpolatingCompilationDatabase.cpp:353
+      }
+      Best = Candidate.first;
+      BestPreferred = Preferred;
----------------
Maybe put these fields into `struct Candidate {}`?
The code would, arguably, be easier to read. Up to you.


Repository:
  rC Clang

https://reviews.llvm.org/D45006





More information about the cfe-commits mailing list