[PATCH] D45382: [CodeGen] Avoid destructing a struct type that has already been destructed by a delegated constructor
Akira Hatanaka via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Apr 6 16:19:06 PDT 2018
ahatanak added a comment.
In https://reviews.llvm.org/D45382#1060163, @rjmccall wrote:
> Hmm. I'm not actually sure *why* it's not okay to forward callee-cleanup arguments. Do we just not have the necessary logic to disable the cleanup in the caller?
It seems that it would be OK if there was a way to disable the cleanup in the caller when we know that we are delegating to another constructor, possibly by setting the DelegateCXXConstructorCall here too. But maybe there are other reasons for not doing so.
Perhaps Richard (who committed r274049) knows why we can't call the delegated constructor when there are callee-cleanup arguments?
Repository:
rC Clang
https://reviews.llvm.org/D45382
More information about the cfe-commits
mailing list