[PATCH] D45254: [X86][WAITPKG] WaitPKG intrinsics

[Gabor Buella via Phabricator via cfe-commits]

GBuella added inline comments.


================
Comment at: lib/Headers/waitpkgintrin.h:41
+static __inline__ void __DEFAULT_FN_ATTRS
+_umwait (__SIZE_TYPE__  __CONTROL, __UINT64_TYPE__  __COUNTER)
+{
----------------
craig.topper wrote:
> Why does the intrinsic take size_t but then its truncated to 32 bits?
When I replaced umwait32 & umwait64 with a single umwait LLVM intrinsic, I choose i32 as the type of the first argument.
The doc says:
bit[0] has a meaning, while bit[31:1] are reserved.
The doc doesn't suggest that the upper 32 bits might ever be used.
But I see, this might need some more discussion.


https://reviews.llvm.org/D45254