[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

[Manoj Gupta via Phabricator via cfe-commits]

manojgupta added a comment.

I think the tests are already broken in Gentoo when clang is installed in /usr/bin even without this patch.  The tests only work if clang binary is not installed in /usr/bin.

RootCause is the existing lines in Gnu.cpp:

      

  // Then look for gcc installed alongside clang.
  Prefixes.push_back(D.InstalledDir + "/..");

e.g. Specified debian sysroot is not picked  as expected for the following command line.

$ clang -v --target=i386-unknown-linux   --gcc-toolchain=""   --sysroot=test/Driver/Inputs/debian_multiarch_tree 2>&1 
clang version 7.0.0
Target: i386-unknown-linux
Thread model: posix
InstalledDir: /usr/bin
Found candidate GCC installation: /usr/bin/../lib/gcc/i686-pc-linux-gnu/4.9.x
Found candidate GCC installation: /usr/bin/../lib/gcc/x86_64-pc-linux-gnu/4.9.x
Found candidate GCC installation: /usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/4.9.x
Found candidate GCC installation: test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc/i686-linux-gnu/4.5
Found candidate GCC installation: test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc/x86_64-linux-gnu/4.5
Selected GCC installation: /usr/bin/../lib/gcc/i686-pc-linux-gnu/4.9.x
Candidate multilib: .;@m32
Selected multilib: .;@m32


Repository:
  rC Clang

https://reviews.llvm.org/D45233