[PATCH] D45096: Allow the creation of human-friendly ASTDumper to arbitrary output stream

Alexander Kornienko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 5 06:25:56 PDT 2018


alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.

Looks good to me. One optional comment.



================
Comment at: include/clang/Frontend/ASTConsumers.h:39-41
 std::unique_ptr<ASTConsumer> CreateASTDumper(StringRef FilterString,
                                              bool DumpDecls, bool Deserialize,
                                              bool DumpLookups);
----------------
With just three users of the old API it might make sense to just add a parameter to it and update the callers instead of adding another override.


Repository:
  rC Clang

https://reviews.llvm.org/D45096





More information about the cfe-commits mailing list