[PATCH] D45289: Disable -fmerge-all-constants as default.
Manoj Gupta via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Apr 4 16:02:36 PDT 2018
manojgupta added inline comments.
================
Comment at: include/clang/Driver/Options.td:1286
def fno_merge_all_constants : Flag<["-"], "fno-merge-all-constants">, Group<f_Group>,
Flags<[CC1Option]>, HelpText<"Disallow merging of constants">;
def fno_modules : Flag <["-"], "fno-modules">, Group<f_Group>,
----------------
rjmccall wrote:
> rsmith wrote:
> > Remove the `Flags<[CC1Option]>` here, since `-cc1` no longer understands this flag.
> Did you mean to remove the help text here? It's still a meaningful driver option.
I agree that it is meaningful and also useful to have the help text around. I had removed it since previously "fmerge-all-constants" didn't have it.
Repository:
rC Clang
https://reviews.llvm.org/D45289
More information about the cfe-commits
mailing list