[PATCH] D44411: [libc++] Fix Container::insert(value_type const&) tests
Eric Fiselier via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Apr 3 17:13:34 PDT 2018
EricWF added a comment.
Have you verified that we're not losing test coverage here? That is, are you sure we still have tests for the rvalue overloads in other test files?
================
Comment at: libcxx/test/std/containers/associative/multiset/insert_cv.pass.cpp:41
+ const VT v3(3);
+ r = m.insert(3);
+ assert(r == prev(m.end()));
----------------
Should be `v3`?
Repository:
rCXX libc++
https://reviews.llvm.org/D44411
More information about the cfe-commits
mailing list