[PATCH] D45056: [X86] Split up -march=icelake to -client & -server

Craig Topper via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 3 14:31:47 PDT 2018


craig.topper added inline comments.


================
Comment at: test/Preprocessor/predefined-arch-macros.c:1164
+// CHECK_ICX_M32: #define __corei7 1
+// CHECK_ICX_M32: #define __corei7__ 1
+// CHECK_ICX_M32: #define __i386 1
----------------
The ICX_M32 and ICX_M64 should be contiguous in the file. The file is grouped by CPUs with the 32 and 64 bit together.


Repository:
  rC Clang

https://reviews.llvm.org/D45056





More information about the cfe-commits mailing list