[PATCH] D45179: [libc++] Add _LIBCPP_FORCE_NODISCARD define to force-enable nodiscard in pre-C++17

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 3 13:34:04 PDT 2018


lebedev.ri added a comment.

In https://reviews.llvm.org/D45179#1056108, @Quuxplusone wrote:

> > Opt-in is an enhancement. Of course, it would be nice to always default it to on, but as it was disscussed with @mclow.lists, this is simply not going to happen. This is the best we'll get.
>
> Is @mclow.lists on record anywhere as saying that, that you could link to?


That particular disscussion was in IRC, so no, i can not link/paste.

> I ask because I haven't seen him commenting on these patches.



> At the moment, it seems like you're alone in both pushing these patches and simultaneously arguing that any effort is futile. :)

:)


Repository:
  rCXX libc++

https://reviews.llvm.org/D45179





More information about the cfe-commits mailing list