[PATCH] D44773: [CMake] Use custom command and target to install libc++ headers

Eric Fiselier via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 3 00:00:29 PDT 2018


EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.

This LGTM modulo requested changes.

There's a section in `NOTES.TXT` about the steps required for adding a header. Please update that to mention listing it in CMake.



================
Comment at: libcxx/include/CMakeLists.txt:151
+
+if(LIBCXX_ENABLE_EXPERIMENTAL_LIBRARY)
+  set(files
----------------
We still want to install the experimental headers even if the experimental library build isn't enabled. Header only components still function. 


Repository:
  rCXX libc++

https://reviews.llvm.org/D44773





More information about the cfe-commits mailing list