[PATCH] D45163: [Sema] -Wunused-value: diagnose unused std::move() call results.

[Arthur O'Dwyer via Phabricator via cfe-commits]

Quuxplusone added a comment.

`std::move` would definitely be special in this regard if there were a pressing benefit to be gained — i.e., if people were currently getting bitten by accidentally discarded calls of `std::move(x)`. But you haven't shown that people are getting bitten today; in fact I think you said the opposite, right? that there were *no* instances of this happening in the real codebases you tested? So in that case, this diagnostic doesn't have a pressing benefit IMHO, and Clang could safely wait for the library vendors to do the work.


Repository:
  rC Clang

https://reviews.llvm.org/D45163