[PATCH] D44883: [Sema] Extend -Wself-assign and -Wself-assign-field to warn on overloaded self-assignment (classes)

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 2 09:13:14 PDT 2018


rjmccall added a comment.

Right.  I think it's fair to acknowledge that many data structure unit tests will contain a legitimate use of a user-defined self-assignment without feeling that that disqualifies the warning.

Note that the purpose of this kind of breadth testing is just to look for false positives.  It shouldn't be discouraging if the warning doesn't find any real bugs in existing code.


Repository:
  rC Clang

https://reviews.llvm.org/D44883





More information about the cfe-commits mailing list