[PATCH] D45061: [NVPTX, CUDA] Use custom feature detection to handle NVPTX target builtins.

Eric Christopher via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Mar 31 13:04:49 PDT 2018


echristo added a comment.

The llvm change and corresponding switch from satom->sm_60 in the front end is fine.

Let's talk about the rest of it more. I'm not sure I'm seeing the need here rather than the annotations that are already here. Can you elaborate more here on why we need an additional method when you've already got subtarget features for each of the ptx versions anyhow?

Thanks.

-eric


https://reviews.llvm.org/D45061





More information about the cfe-commits mailing list