[PATCH] D45112: [MS] Emit vftable thunks for functions with incomplete prototypes

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Mar 31 10:16:41 PDT 2018


rnk added a comment.

In https://reviews.llvm.org/D45112#1053539, @majnemer wrote:

> Does this help PR25641?


I think so, these are probably duplicate PRs. I think your analysis on that bug is slightly off, because the TU that provides `ImplCanvas::createColor` *can't* provide the thunks that `ImplBitmapCanvas` needs. It has no way to predict how the offset from the virtual base to the final overrider will change in derived classes.


https://reviews.llvm.org/D45112





More information about the cfe-commits mailing list