[PATCH] D45101: [ObjC] Use the name specified by objc_runtime_name instead of the class identifier

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 30 20:19:26 PDT 2018


rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D45101#1053246, @ahatanak wrote:

> Note that CGObjCNonFragileABIMac::EmitClassRef also passes the class identifier to CGObjCNonFragileABIMac::EmitClassRefFromId, but it doesn't cause a problem. CGObjCNonFragileABIMac::EmitClassRefFromId uses the identifier only when the ObjCInterfaceDecl passed to it is null and that happens only when it is called from CGObjCNonFragileABIMac::EmitNSAutoreleasePoolClassRef.


Hmm.  Alright.

LGTM.


Repository:
  rC Clang

https://reviews.llvm.org/D45101





More information about the cfe-commits mailing list