[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

Zinovy Nis via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 30 12:45:02 PDT 2018


zinovy.nis added a comment.

BTW, I've recently found few dozens of issues in the Chromium code with my check.
For ex.:

  browser/src/cc/layers/nine_patch_layer_impl.cc:89:51: warning: qualified name 'cc::LayerImpl::LayerAsJson' refers to a member overridden in subclass; did you mean 'cc::UIResourceLayerImpl'? [bugprone-parent-virtual-call]
    std::unique_ptr<base::DictionaryValue> result = LayerImpl::LayerAsJson();
                                                    ^~~~~~~~~~~~~~~~~~~~~~
                                                    cc::UIResourceLayerImpl::


https://reviews.llvm.org/D44295





More information about the cfe-commits mailing list