[PATCH] D44764: [clangd] Use operator<< to prevent printers issues in Gtest

Marc-Andre Laperle via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 29 20:49:03 PDT 2018


malaperle added inline comments.


================
Comment at: clangd/Protocol.h:673
 json::Expr toJSON(const CompletionItem &);
+std::ostream &operator<<(std::ostream &, const CompletionItem &);
 
----------------
sammccall wrote:
> I think raw_ostream should work fine here, it's what we've done elsewhere.
> Is there a reason to use std::ostream?
> 
> (llvm's gtest is specially modified so raw_ostream printers can be used)
No reason, I changed it.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D44764





More information about the cfe-commits mailing list