[PATCH] D45060: Allow target to handle required features for TARGET_BUILTINs.

[Artem Belevich via Phabricator via cfe-commits]

tra marked an inline comment as done.
tra added inline comments.


================
Comment at: clang/include/clang/Basic/TargetInfo.h:933
+  /// FeatureMap. Targets may override this to provide custom handling of
+  /// required features.
+  virtual Optional<bool>
----------------
jlebar wrote:
> It's not totally obvious to me, can we explain why it's a tristate?
We need to distinguish between "target does not need to do anything special about the feature" (no value) and "target does have an opinion, which may be true or false.". I'll update the comment.


https://reviews.llvm.org/D45060