[PATCH] D44720: [clangd] Simplify fuzzy matcher (sequence alignment) by removing some condition checks.
Fangrui Song via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Mar 29 12:18:45 PDT 2018
MaskRay added inline comments.
================
Comment at: clangd/FuzzyMatch.cpp:209
std::copy(NewWord.begin(), NewWord.begin() + WordN, Word);
- if (PatN == 0)
- return true;
----------------
sammccall wrote:
> similarly this one.
> (ideally we wouldn't do the work above, it's just there to make dumpLast work I think)
This is very cheap and dumpLast has checked the emptiness so there is no need to duplicate the work here.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44720
More information about the cfe-commits
mailing list