[PATCH] D44765: PR36643 Make clang-format support more generic TMarcos

Krasimir Georgiev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 29 02:47:10 PDT 2018


krasimir added inline comments.


================
Comment at: lib/Format/FormatTokenLexer.cpp:386
   String->HasUnescapedNewline = Macro->HasUnescapedNewline;
+  String->TMacroStringLiteral = true;
 
----------------
In the original code, TMacro detection was done as:
```
(Text.startswith(Prefix = "_T(\"") && Text.endswith(Postfix = "\")"))
```
In the new code the left part is saved in TMacroStringLiteral, and the right part is checked in ContinuationIndenter. Could you keep them together in `FormatTokenLexer`.
@alexfh, why are we checking for the right check at all? What would be an example where this is needed to disambiguate?



https://reviews.llvm.org/D44765





More information about the cfe-commits mailing list