[PATCH] D44381: [mips] Prevent PIC to be set to level 2

[Simon Dardis via Phabricator via cfe-commits]

sdardis added inline comments.


================
Comment at: lib/Driver/ToolChains/CommonArgs.cpp:983
+      return std::make_tuple(llvm::Reloc::Static, 0U, false);
+    // It's never PIC level 2 for mips.
+    IsPICLevelTwo = false;
----------------
Can you reformulate this comment to say that MIPS does not use PIC level 2? Also, please add a note stating that even with -mxgot / -fPIC / multigot , MIPS does not use PIC level 2 unlike other architecutres for historical reasons.


Repository:
  rC Clang

https://reviews.llvm.org/D44381