[PATCH] D44931: [WebAssembly] Use Windows EH instructions for Wasm EH

Derek Schuff via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 28 16:20:20 PDT 2018


dschuff added inline comments.


================
Comment at: lib/CodeGen/CGException.cpp:1541
+  }
   llvm::CallInst *terminateCall =
+      CGM.getCXXABI().emitTerminateForUnexpectedException(*this, Exn);
----------------
aheejin wrote:
> dschuff wrote:
> > Should this be in an else block? No need to emit it after we emit the call to `__clang_call_terminate`
> I don't understand? The call emitted within the `if` block is not a call to `__clang_call_terminate` but to `wasm.get.exception` intrinsic.
Oh you're right, I misread that, nevermind.


Repository:
  rC Clang

https://reviews.llvm.org/D44931





More information about the cfe-commits mailing list