[PATCH] D44747: Set calling convention for CUDA kernel

Yaxun Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 28 11:54:58 PDT 2018


yaxunl added a comment.

Matt, are you OK with the change from amdgcn backend point of view? Thanks.



================
Comment at: lib/Sema/SemaExpr.cpp:1669
+    }
+  }
+
----------------
rjmccall wrote:
> You should use `getAs<FunctionType>` here (no `const` necessary).  It's possible to declare a function with a typedef of function type, you just can't define it that way.
will do.


https://reviews.llvm.org/D44747





More information about the cfe-commits mailing list