[PATCH] D44931: [WebAssembly] Use Windows EH instructions for Wasm EH

[David Majnemer via Phabricator via cfe-commits]

majnemer added a comment.

Some quick first pass comments.



================
Comment at: lib/CodeGen/CGCleanup.cpp:985
+    // does not have a runtime support for that.
+    if (!Personality.usesFuncletPads() || Personality.isWasmPersonality()) {
+      EHStack.pushTerminate();
----------------
I think this condition can be simplified to `!isMSVCPersonality()` with a slight tweak of the comment.


================
Comment at: test/CodeGenCXX/wasm-eh.cpp:33
+// CHECK-NEXT:   %[[CATCHPAD:.*]] = catchpad within %[[CATCHSWITCH]] [i8* bitcast (i8** @_ZTIi to i8*), i8* bitcast (i8** @_ZTId to i8*)]
+// CHECK-NEXT:   %[[EXN:.*]] = call i8* @llvm.wasm.get.exception()
+// CHECK-NEXT:   store i8* %[[EXN]], i8** %exn.slot
----------------
I'd expect a funclet bundle operand here..


Repository:
  rC Clang

https://reviews.llvm.org/D44931