[PATCH] D44882: [clangd] Implementation of workspace/symbol request

Tue Mar 27 13:31:06 PDT 2018

MaskRay added inline comments.

================
Comment at: clangd/tool/ClangdMain.cpp:105

+static llvm::cl::opt<int> LimitWorkspaceSymbolResult(
+    "workspace-symbol-limit",
----------------
malaperle wrote:
> sammccall wrote:
> > the -completion-limit was mostly to control rollout, I'm not sure this needs to be a flag. If it does, can we make it the same flag as completions (and call it -limit or so?)
> I think it's quite similar to "completions", when you type just one letter for example, you can get a lot of results and a lot of JSON output. So it feels like the flag could apply to both completions and workspace symbols. How about -limit-resuts? I think just -limit might be a bit too general as we might want to limit other things.
Can these options be set by LSP initialization options?

Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D44882