[PATCH] D44723: Set dso_local when clearing dllimport

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 27 12:17:01 PDT 2018


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm

I'd add more tests but I can't think of ways to remove the dll attributes, only to flip them.

Do we already have dso_local tests for this similar case:

  __declspec(dllimport) void f();
  void g() { f(); } // use it
  void f() { }

It flips from dllimport to dllexport.


https://reviews.llvm.org/D44723





More information about the cfe-commits mailing list