[PATCH] D44883: [Sema] Extend -Wself-assign and -Wself-assign-field to warn on overloaded self-assignment (classes)

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 27 10:00:19 PDT 2018


lebedev.ri updated this revision to Diff 139948.
lebedev.ri retitled this revision from "[Sema] Extend -Wself-assign with -Wself-assign-overloaded to warn on overloaded self-assignment (classes)" to "[Sema] Extend -Wself-assign and -Wself-assign-field to warn on overloaded self-assignment (classes)".
lebedev.ri edited the summary of this revision.
lebedev.ri added a comment.

- Dropped separate `-Wself-assign-builtin` and `-Wself-assign-overloaded` groups
- Simply updated the existing `-Wself-assign` and `-Wself-assign-field`.
- Significantly improved test coverage.
- `ninja check-clang` passes. Did not do stage2 build yet.
- `-Wself-assign-field` is rather neglected - unlike `-Wself-assign`, it does incorrectly warn on self-operations with `volatile` stores, and macros.


Repository:
  rC Clang

https://reviews.llvm.org/D44883

Files:
  docs/ReleaseNotes.rst
  lib/Sema/SemaExpr.cpp
  test/SemaCXX/implicit-exception-spec.cpp
  test/SemaCXX/member-init.cpp
  test/SemaCXX/warn-self-assign-builtin.cpp
  test/SemaCXX/warn-self-assign-field-builtin.cpp
  test/SemaCXX/warn-self-assign-field-overloaded.cpp
  test/SemaCXX/warn-self-assign-overloaded.cpp
  test/SemaCXX/warn-self-assign.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D44883.139948.patch
Type: text/x-patch
Size: 13282 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180327/40797416/attachment.bin>


More information about the cfe-commits mailing list