[PATCH] D44823: [libcxx] Improving std::vector<char> and std::deque<char> perfomance

[Marshall Clow via Phabricator via cfe-commits]

mclow.lists requested changes to this revision.
mclow.lists added a comment.
This revision now requires changes to proceed.

Please don't commit this.



================
Comment at: libcxx/trunk/include/__split_buffer:201
     __alloc_rr& __a = this->__alloc();
+    pointer __to_be_end = this->__end_;
     do
----------------
I have been asked specifically by the optimizer folks to NOT do things like this in libc++, but rather to file bugs against the optimizer.

And I have done so for this exact case:  https://bugs.llvm.org/show_bug.cgi?id=35637


Repository:
  rCXX libc++

https://reviews.llvm.org/D44823