[PATCH] D41648: [clang-tidy] implement cppcoreguidelines macro rules

Eugene Zelenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 26 09:04:07 PDT 2018


Eugene.Zelenko added inline comments.


================
Comment at: docs/clang-tidy/checks/cppcoreguidelines-macro-usage.rst:26
+
+    This boolean flag disables all warnings for macros and checks only that 
+    macro names are CAPS_ONLY. This option is meant to ease introduction of this
----------------
Will be good idea to rephrase statement: //except those with CAPS_ONLY names//?


================
Comment at: docs/clang-tidy/checks/cppcoreguidelines-macro-usage.rst:27
+    This boolean flag disables all warnings for macros and checks only that 
+    macro names are CAPS_ONLY. This option is meant to ease introduction of this
+    check into older code bases. Default value is `0`/`false`.
----------------
is //intended//?


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D41648





More information about the cfe-commits mailing list