[PATCH] D44602: [clang-tidy] readability-function-size: add VariableThreshold param.

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Mar 24 08:16:57 PDT 2018


lebedev.ri updated this revision to Diff 139711.
lebedev.ri marked 15 inline comments as done.
lebedev.ri added a comment.

- Rebased ontop of master
- Fixed links in documentation
- Improved test coverage
- No longer count variables declared in nested `class`es.
- No longer count variables declared in nested lambdas. FIXME: this check()` is not being called for lambdas at all. But out of the scope of this patch.
- No longer count variables declared in macro expansion. Please see FIXME, i think this is too broad.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D44602

Files:
  clang-tidy/readability/FunctionSizeCheck.cpp
  clang-tidy/readability/FunctionSizeCheck.h
  docs/ReleaseNotes.rst
  docs/clang-tidy/checks/readability-function-size.rst
  test/clang-tidy/readability-function-size-variables-c++17.cpp
  test/clang-tidy/readability-function-size.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D44602.139711.patch
Type: text/x-patch
Size: 18616 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180324/fc2afd4f/attachment-0001.bin>


More information about the cfe-commits mailing list