[PATCH] D44846: [MS] Fix late-parsed template infinite loop in eager instantiation

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 23 15:44:44 PDT 2018


rnk added inline comments.


================
Comment at: clang/lib/Sema/Sema.cpp:855
   // instantiations. PCH files do not.
   if (TUKind != TU_Prefix) {
     DiagnoseUseOfUnimplementedSelectors();
----------------
rsmith wrote:
> In the TUPrefix case, we'll need to write these instantiations to the PCH file.
I think this addresses that. Now that we are at global scope, nobody will eagerly attempt to instantiate everything on the pending instantiation queue until end of TU.


https://reviews.llvm.org/D44846





More information about the cfe-commits mailing list