[PATCH] D44589: [Sema] Make deprecation fix-it replace all multi-parameter ObjC method slots.

Volodymyr Sapsai via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 23 14:01:08 PDT 2018


vsapsai updated this revision to Diff 139650.
vsapsai added a comment.

Address review comments:

- update comments for tryParseObjCMethodName, use isValidIdentifier.
- make MultiSourceLocation more lightweight.

I have rebased my patch, so diff between changes can be noisy.


https://reviews.llvm.org/D44589

Files:
  clang/include/clang/Basic/CharInfo.h
  clang/include/clang/Basic/SourceLocation.h
  clang/include/clang/Sema/DelayedDiagnostic.h
  clang/include/clang/Sema/Sema.h
  clang/lib/Sema/DelayedDiagnostic.cpp
  clang/lib/Sema/SemaDeclAttr.cpp
  clang/lib/Sema/SemaExpr.cpp
  clang/lib/Sema/SemaExprObjC.cpp
  clang/test/SemaObjC/attr-deprecated-replacement-fixit.m
  clang/unittests/Basic/CharInfoTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D44589.139650.patch
Type: text/x-patch
Size: 30364 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180323/dac95dbc/attachment-0001.bin>


More information about the cfe-commits mailing list