[PATCH] D44826: Add -Wunused-using, a warning that finds unused using declarations.
Carlos Alberto Enciso via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Mar 23 08:22:26 PDT 2018
CarlosAlbertoEnciso added a comment.
In https://reviews.llvm.org/D44826#1046671, @erichkeane wrote:
> My opinion matters less than @rsmith or @dblaikie on the review, but it seems to me that Typedef and Using are SO similar that the implementations should just be combined. You'd likely have to change a couple of types along the way to be more generic, but the implementations are essentially a copy/paste of eachother.
That is a very valid point and it simplifies quite a lot the patch.
If the other reviewers do not have any objection, I will combine both implementations and update the uploaded patch.
Thanks,
Carlos
Repository:
rC Clang
https://reviews.llvm.org/D44826
More information about the cfe-commits
mailing list