[PATCH] D37014: [clang-tidy] Add a checker to remove useless intermediate variables before return statements with comparisons

Eugene Zelenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 23 08:07:35 PDT 2018


Eugene.Zelenko added inline comments.


================
Comment at: docs/ReleaseNotes.rst:62
 
 - New `bugprone-throw-keyword-missing
   <http://clang.llvm.org/extra/clang-tidy/checks/bugprone-throw-keyword-missing.html>`_ check
----------------
Please rebase from trunk and use //:doc:// for link.


================
Comment at: docs/ReleaseNotes.rst:82
+
+  This new check detects unnecessary intermediate variables before `return`
+  statements that return the result of a simple comparison. This check also
----------------
Please remove This new check. Please enclose return in ``, also in other places.


================
Comment at: docs/clang-tidy/checks/readability-unnecessary-intermediate-var.rst:7
+Detects unnecessary intermediate variables before `return` statements returning the
+result of a simple comparison. This checker also suggests to directly inline the
+initializer expression of the variable declaration into the `return` expression.
----------------
Checker -> check.


https://reviews.llvm.org/D37014





More information about the cfe-commits mailing list