[PATCH] D44764: [clangd] Use a header for common inclusions for tests

[Simon Marchi via Phabricator via cfe-commits]

simark accepted this revision.
simark added inline comments.


================
Comment at: unittests/clangd/Printers.h:12
+// objects on failure. Otherwise, it is possible that there will be two
+// different instantiations of the printer template for a given type and some
+// tests could end up calling the wrong (default) one.
----------------
To be more precise, I think it's linker keeping only one of the two versions, so it's _all_ tests, not some, that may end up calling the wrong (default) one.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D44764